[all-commits] [llvm/llvm-project] c6f13c: [llvm-objdump][NFC] MachODump.cpp interface cleanup

Hubert Tong via All-commits all-commits at lists.llvm.org
Thu Apr 9 12:35:50 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c6f13ce580756da6d82497d84d277abdc5ab753c
      https://github.com/llvm/llvm-project/commit/c6f13ce580756da6d82497d84d277abdc5ab753c
  Author: Hubert Tong <hubert.reinterpretcast at gmail.com>
  Date:   2020-04-09 (Thu, 09 Apr 2020)

  Changed paths:
    M llvm/tools/llvm-objdump/MachODump.cpp
    M llvm/tools/llvm-objdump/MachODump.h
    M llvm/tools/llvm-objdump/llvm-objdump.cpp
    M llvm/tools/llvm-objdump/llvm-objdump.h

  Log Message:
  -----------
  [llvm-objdump][NFC] MachODump.cpp interface cleanup

Continuing from D77388, this patch moves interface declarations
associated with `MachODump.cpp` into the headers corresponding to the
file that defines the variable. At the same time, these externs are
moved into the `llvm::objdump` namespace. The externs defined in
`MachODump.cpp` that are not referenced outside of it are given internal
linkage.

This patch does not rename the external functions defined by
`MachODump.cpp` that are not clearly named as being specific to Mach-O.

Reviewed By: jhenderson, MaskRay

Differential Revision: https://reviews.llvm.org/D77730




More information about the All-commits mailing list