[all-commits] [llvm/llvm-project] 48e65f: MachineFunction: Copy call site info when duplicat...

Vedant Kumar via All-commits all-commits at lists.llvm.org
Wed Apr 8 11:06:49 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 48e65fc63076eec4fa527ab7b22fdcb4d8cdbb50
      https://github.com/llvm/llvm-project/commit/48e65fc63076eec4fa527ab7b22fdcb4d8cdbb50
  Author: Vedant Kumar <vsk at apple.com>
  Date:   2020-04-08 (Wed, 08 Apr 2020)

  Changed paths:
    M llvm/lib/CodeGen/MachineFunction.cpp
    A llvm/test/CodeGen/X86/taildup-callsiteinfo.mir
    M llvm/unittests/CodeGen/MFCommon.inc
    M llvm/unittests/CodeGen/MachineInstrTest.cpp

  Log Message:
  -----------
  MachineFunction: Copy call site info when duplicating insts

Summary:
Preserve call site info for duplicated instructions. We copy over the
call site info in CloneMachineInstrBundle to avoid repeated calls to
copyCallSiteInfo in CloneMachineInstr.

(Alternatively, we could copy call site info higher up the stack, e.g.
into TargetInstrInfo::duplicate, or even into individual backend passes.
However, I don't see how that would be safer or more general than the
current approach.)

Reviewers: aprantl, djtodoro, dstenb

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77685




More information about the All-commits mailing list