[all-commits] [llvm/llvm-project] c8de17: Fix illegal early call to PyBuffer_Release in swig...

smoofra via All-commits all-commits at lists.llvm.org
Tue Apr 7 13:31:36 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c8de17bca658e62bbf8c33eae839e457332e885e
      https://github.com/llvm/llvm-project/commit/c8de17bca658e62bbf8c33eae839e457332e885e
  Author: Lawrence D'Anna <lawrence_danna at apple.com>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M lldb/bindings/python/python-typemaps.swig

  Log Message:
  -----------
  Fix illegal early call to PyBuffer_Release in swig typemaps

Summary:
The buffer protocol does not allow us to just call PyBuffer_Release
and assume the buffer will still be there.   Most things that implement the
buffer protocol will let us get away with that, but not all.   We need
to release it at the end of the SWIG wrapper.

Reviewers: labath, jasonmolenda, JDevlieghere, vadimcn

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D77480




More information about the All-commits mailing list