[all-commits] [llvm/llvm-project] f5deb0: Remove FxpMathOps dialect and Quantizer tool.

Stella Laurenzo via All-commits all-commits at lists.llvm.org
Tue Apr 7 13:23:38 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f5deb0878d9a381a246d30b87a180b4369bf4ea8
      https://github.com/llvm/llvm-project/commit/f5deb0878d9a381a246d30b87a180b4369bf4ea8
  Author: Stella Laurenzo <stellaraccident at gmail.com>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M mlir/docs/Passes.md
    M mlir/docs/Quantization.md
    M mlir/examples/standalone/standalone-opt/CMakeLists.txt
    M mlir/include/mlir/CMakeLists.txt
    M mlir/include/mlir/Dialect/CMakeLists.txt
    R mlir/include/mlir/Dialect/FxpMathOps/CMakeLists.txt
    R mlir/include/mlir/Dialect/FxpMathOps/FxpMathOps.h
    R mlir/include/mlir/Dialect/FxpMathOps/FxpMathOps.td
    R mlir/include/mlir/Dialect/FxpMathOps/Passes.h
    R mlir/include/mlir/Dialect/FxpMathOps/Passes.td
    M mlir/include/mlir/InitAllDialects.h
    M mlir/include/mlir/InitAllPasses.h
    R mlir/include/mlir/Quantizer/CMakeLists.txt
    R mlir/include/mlir/Quantizer/Configurations/FxpMathConfig.h
    R mlir/include/mlir/Quantizer/Support/Configuration.h
    R mlir/include/mlir/Quantizer/Support/ConstraintAnalysisGraph.h
    R mlir/include/mlir/Quantizer/Support/ConstraintAnalysisGraphTraits.h
    R mlir/include/mlir/Quantizer/Support/Metadata.h
    R mlir/include/mlir/Quantizer/Support/Rules.h
    R mlir/include/mlir/Quantizer/Support/Statistics.h
    R mlir/include/mlir/Quantizer/Support/TypeUtils.h
    R mlir/include/mlir/Quantizer/Support/UniformConstraints.h
    R mlir/include/mlir/Quantizer/Support/UniformSolvers.h
    R mlir/include/mlir/Quantizer/Transforms/CMakeLists.txt
    R mlir/include/mlir/Quantizer/Transforms/Passes.h
    R mlir/include/mlir/Quantizer/Transforms/Passes.td
    M mlir/lib/CMakeLists.txt
    M mlir/lib/Dialect/CMakeLists.txt
    R mlir/lib/Dialect/FxpMathOps/CMakeLists.txt
    R mlir/lib/Dialect/FxpMathOps/IR/FxpMathOps.cpp
    R mlir/lib/Dialect/FxpMathOps/Transforms/LowerUniformRealMath.cpp
    R mlir/lib/Dialect/FxpMathOps/Transforms/UniformKernelUtils.h
    R mlir/lib/Quantizer/CMakeLists.txt
    R mlir/lib/Quantizer/Configurations/FxpMathConfig.cpp
    R mlir/lib/Quantizer/Support/Configuration.cpp
    R mlir/lib/Quantizer/Support/ConstraintAnalysisGraph.cpp
    R mlir/lib/Quantizer/Support/Metadata.cpp
    R mlir/lib/Quantizer/Support/Statistics.cpp
    R mlir/lib/Quantizer/Support/TypeUtils.cpp
    R mlir/lib/Quantizer/Support/UniformConstraints.cpp
    R mlir/lib/Quantizer/Support/UniformSolvers.cpp
    R mlir/lib/Quantizer/Transforms/AddDefaultStatsTestPass.cpp
    R mlir/lib/Quantizer/Transforms/InferQuantizedTypesPass.cpp
    R mlir/lib/Quantizer/Transforms/RemoveInstrumentationPass.cpp
    R mlir/test/Dialect/FxpMathOps/lower-uniform-casts.mlir
    R mlir/test/Dialect/FxpMathOps/lower-uniform-real-math-addew.mlir
    R mlir/test/Dialect/FxpMathOps/lower-uniform-real-math-mulew.mlir
    R mlir/test/Quantizer/matmul.mlir
    R mlir/test/Quantizer/remove-instrumentation.mlir
    M mlir/test/mlir-opt/commandline.mlir
    M mlir/tools/mlir-opt/CMakeLists.txt
    R mlir/unittests/Quantizer/Support/RulesTest.cpp
    R mlir/unittests/Quantizer/Support/UniformSolversTest.cpp

  Log Message:
  -----------
  Remove FxpMathOps dialect and Quantizer tool.

Summary:
* Removal of FxpMathOps was discussed on the mailing list.
* Will send a courtesy note about also removing the Quantizer (which had some dependencies on FxpMathOps).
* These were only ever used for experimental purposes and we know how to get them back from history as needed.
* There is a new proposal for more generalized quantization tooling, so moving these older experiments out of the way helps clean things up.

Subscribers: mgorny, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77479




More information about the All-commits mailing list