[all-commits] [llvm/llvm-project] c0a33a: [mlir][Diagnostic] Don't store Operation arguments...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c0a33aaa804847e74e1514ce881d43435e94c172
      https://github.com/llvm/llvm-project/commit/c0a33aaa804847e74e1514ce881d43435e94c172
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M mlir/include/mlir/IR/Diagnostics.h
    M mlir/lib/IR/Diagnostics.cpp

  Log Message:
  -----------
  [mlir][Diagnostic] Don't store Operation arguments as a DiagnosticArgument

Summary: Diagnostics may be cached in the parallel diagnostic handler to preserve proper ordering. Storing the Operation as a DiagnosticArgument is problematic as the operation may be erased or changed before it finally gets printed.

Differential Revision: https://reviews.llvm.org/D77675