[all-commits] [llvm/llvm-project] 4ac7b8: [clangd] Get rid of ASTWorker::getCurrentFileInputs

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Tue Apr 7 04:48:50 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ac7b805b7c4aa7af0a82d6187e3bd6ac0cf38cd
      https://github.com/llvm/llvm-project/commit/4ac7b805b7c4aa7af0a82d6187e3bd6ac0cf38cd
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M clang-tools-extra/clangd/TUScheduler.cpp

  Log Message:
  -----------
  [clangd] Get rid of ASTWorker::getCurrentFileInputs

Summary:
FileInputs are only written by ASTWorker thread, therefore it is safe
to read them without the lock inside that thread. It can still be read by other
threads through ASTWorker::getCurrentCompileCommand though.

This patch also gets rid of the smart pointer wrapping FileInputs as there is
never mutliple owners.

Reviewers: sammccall

Subscribers: ilya-biryukov, javed.absar, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77309


  Commit: 59c28103a4a4d05db036157605a52a8075d60082
      https://github.com/llvm/llvm-project/commit/59c28103a4a4d05db036157605a52a8075d60082
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-04-07 (Tue, 07 Apr 2020)

  Changed paths:
    M clang-tools-extra/clangd/Headers.cpp

  Log Message:
  -----------
  [clangd] Fix printing for Inclusion


Compare: https://github.com/llvm/llvm-project/compare/7fc599ceb015...59c28103a4a4


More information about the All-commits mailing list