[all-commits] [llvm/llvm-project] 41ba80: [CallSite Removal] a CallBase is never an Indirect...

[Nick Desaulniers via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 41ba80182cc2540fcf85bcda10bbde04816b7e6e
      https://github.com/llvm/llvm-project/commit/41ba80182cc2540fcf85bcda10bbde04816b7e6e
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M llvm/lib/IR/Instructions.cpp
    A llvm/test/Transforms/PGOProfile/callbr.ll

  Log Message:
  -----------
  [CallSite Removal] a CallBase is never an IndirectCall for isInlineAsm

Summary:
Thanks to Bill Wendling (void) for the report and steps to reproduce.  It looks
like this was missed during r350508's cleanup of the CallSite split into
CallBase, CallInst, and CallBrInst.

This was exposed by running pgo on a callbr, which was creating a ptrtoint to
the inline asm thinking it was an indirect call. The relevant callchain looks
like:

    IndirectCallPromotionPlugin::run()
    -> PGOIndirectCallVisitor::findIndirectCalls()
      -> PGOIndirectCallVisitor::visitCallBase()
        -> CallBase::isIndirectCall()

Reviewers: void, chandlerc

Reviewed By: void

Subscribers: hiraditya, llvm-commits, craig.topper, srhines

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77600