[all-commits] [llvm/llvm-project] 3a2939: Remove math.h/cmath include from DataTypes.h

Reid Kleckner via All-commits all-commits at lists.llvm.org
Mon Apr 6 11:27:57 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3a29393b4709d15069130119cf1d136af4a92d77
      https://github.com/llvm/llvm-project/commit/3a29393b4709d15069130119cf1d136af4a92d77
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M llvm/include/llvm-c/DataTypes.h

  Log Message:
  -----------
  Remove math.h/cmath include from DataTypes.h

DataTypes.h is meant to wrap the integer type and limits headers, which
have some unfortunate variance. The FP math functions declared by math.h
are not unnecessary. math.h took a noticeable amount of time to parse
(~40ms), but that could be startup costs.

Anyway, we don't need to include it, so skipping it can't hurt.

This has been present since the initial CMake build was added in 2008.




More information about the All-commits mailing list