[all-commits] [llvm/llvm-project] 073113: [clang][CodeComplete] Dont perform fallback comple...

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Mon Apr 6 11:08:33 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0731132888a0219179fdb4303cd690a6687cc130
      https://github.com/llvm/llvm-project/commit/0731132888a0219179fdb4303cd690a6687cc130
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M clang/lib/Parse/ParseExpr.cpp
    A clang/test/CodeCompletion/incomplete-member.cpp

  Log Message:
  -----------
  [clang][CodeComplete] Dont perform fallback completion for incomplete member ref

Summary:
Clang performs expression based completion whenever it can't figure out
base of a member reference expression. It might be quite confusing in cases like
incomplete types. This patch disables that fallback.

Unfortunately `ParsePostfixExpressionSuffix` is quite tangled and this patch
adds more to it.

Reviewers: sammccall

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77570




More information about the All-commits mailing list