[all-commits] [llvm/llvm-project] 76221c: Remove llvm::Error include form Diagnostic.h

[Reid Kleckner via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 76221c734eac81387f772aca9299f10a7c921bda
      https://github.com/llvm/llvm-project/commit/76221c734eac81387f772aca9299f10a7c921bda
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M clang-tools-extra/clang-include-fixer/find-all-symbols/PathConfig.cpp
    M clang/include/clang/Basic/Diagnostic.h
    M clang/include/clang/Tooling/Refactoring/ASTSelection.h
    M clang/lib/AST/ExprConstant.cpp
    M clang/lib/AST/Interp/Disasm.cpp
    M clang/lib/Basic/Diagnostic.cpp
    M clang/lib/Lex/LiteralSupport.cpp
    M clang/lib/Sema/CodeCompleteConsumer.cpp
    M clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp
    M clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp
    M clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker.cpp
    M clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp
    M clang/lib/StaticAnalyzer/Core/BugReporter.cpp
    M clang/lib/Tooling/Transformer/SourceCode.cpp

  Log Message:
  -----------
  Remove llvm::Error include form Diagnostic.h

Saves ~400 related LLVM ADT. llvm/ADT/Error.h takes 90ms to parse.

$ diff -u <(sort thedeps-before.txt) <(sort thedeps-after.txt) \
    | grep '^[-+] ' | sort | uniq -c | sort -nr
    403 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/Support/Error.h
    403 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm-c/Error.h
    397 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/Support/Format.h
    397 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/Support/Debug.h
    377 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/ADT/StringExtras.h
    158 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm-c/ExternC.h
    138 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/Support/ErrorOr.h
     13 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/Support/raw_ostream.h
     13 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/ADT/SmallString.h
      5 -    /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/ADT/Twine.h