[all-commits] [llvm/llvm-project] 4e5294: [libc++] Make sure we include %{flags} when buildi...

Louis Dionne via All-commits all-commits at lists.llvm.org
Mon Apr 6 08:24:18 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e52944ef11987efe09681df53700e54222373b8
      https://github.com/llvm/llvm-project/commit/4e52944ef11987efe09681df53700e54222373b8
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M libcxx/test/libcxx/selftest/newformat/sh.cpp/remote-substitutions.sh.cpp
    M libcxx/test/libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp
    M libcxx/utils/libcxx/test/newformat.py

  Log Message:
  -----------
  [libc++] Make sure we include %{flags} when building with the new format

Otherwise, we're missing some flags like the flags that are used by
sanitizer builds and the 32-bit builds. In the long term, I think it
would be better to have only %{compile_flags} and %{link_flags}, but
for the benefit of adopting the new format by default, I think it's OK
to add %{flags} to it.




More information about the All-commits mailing list