[all-commits] [llvm/llvm-project] 9072df: [lldb][nfc] remove overriden funcs with default impl

[Konrad Kleine via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9072df8ac1431dba51394b77ead766aada82867f
      https://github.com/llvm/llvm-project/commit/9072df8ac1431dba51394b77ead766aada82867f
  Author: Konrad Kleine <kkleine at redhat.com>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M lldb/include/lldb/Core/SearchFilter.h
    M lldb/source/Core/SearchFilter.cpp

  Log Message:
  -----------
  [lldb][nfc] remove overriden funcs with default impl

Summary:
These `SearchFilter` methods all return `true` by their default
implementation:

```lang=c++
virtual bool ModulePasses(const FileSpec &spec);
virtual bool ModulePasses(const lldb::ModuleSP &module_sp);
virtual bool AddressPasses(Address &addr);
virtual bool CompUnitPasses(FileSpec &fileSpec);
virtual bool CompUnitPasses(CompileUnit &compUnit);
```

That's why I've documented the default behavior and remove the overrides
(except for `AddressPasses`) in these `SearchFilter`-subclasses which all just
repeated the default implementation: `SearchFilterByModule`,
`SearchFilterByModuleList`.

Reviewers: jankratochvil, labath

Reviewed By: jankratochvil, labath

Subscribers: labath, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D77376