[all-commits] [llvm/llvm-project] 4ede73: [InstCombine] Don't limit uses in eraseInstFromFun...

[Nikita Popov via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ede730096813a9cb901b92fdd3670813cdc5bc1
      https://github.com/llvm/llvm-project/commit/4ede730096813a9cb901b92fdd3670813cdc5bc1
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2020-04-04 (Sat, 04 Apr 2020)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineInternal.h

  Log Message:
  -----------
  [InstCombine] Don't limit uses in eraseInstFromFunction()

eraseInstFromFunction() adds the operands of the erased instructions,
as those might now be dead as well. However, this is limited to
instructions with less than 8 operands.

This check doesn't make a lot of sense to me. As the instruction
gets removed afterwards, I don't see a potential for anything
overly pathological happening here (as we can only add those
operands to the worklist once). The impact on CTMark is in
the noise. We also have the same code in instruction sinking
and don't limit the operand count there.

Differential Revision: https://reviews.llvm.org/D77325