[all-commits] [llvm/llvm-project] 688450: [GraphDiff] Extend GraphDiff to track a list of up...

Alina Sbirlea via All-commits all-commits at lists.llvm.org
Fri Apr 3 12:20:42 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 688450c7f02bbeeabd59eeccd421c8ae03b76ae6
      https://github.com/llvm/llvm-project/commit/688450c7f02bbeeabd59eeccd421c8ae03b76ae6
  Author: Alina Sbirlea <asbirlea at google.com>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M llvm/include/llvm/IR/CFGDiff.h
    M llvm/include/llvm/Support/CFGUpdate.h
    M llvm/lib/Analysis/MemorySSAUpdater.cpp

  Log Message:
  -----------
  [GraphDiff] Extend GraphDiff to track a list of updates.

Summary:
This patch includes two extensions:
1. It extends the GraphDiff to also keep the original list of updates
after legalization, not just the deletes/insert vectors.
It also provides an API to pop the first update (the updates are store
in reverse, such that the first update is at the end of the list)
2. It adds a bool to mark whether the given updates should be applied as
given, or applied in reverse. This moves the task of reversing the
updates (when the caller needs this) to a functionality inside
GraphDiff, versus having the caller do this.

The two changes could be split into two patches, but they seemed
reasonably small to be reviewed together.

Reviewers: kuhar, dblaikie

Subscribers: hiraditya, george.burgess.iv, mgrang, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77167




More information about the All-commits mailing list