[all-commits] [llvm/llvm-project] 222579: [YAMLParser] Scanner::setError - ensure we use the...

[Simon Pilgrim via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 22257975679d20dd87cb3f791708d07c82f53142
      https://github.com/llvm/llvm-project/commit/22257975679d20dd87cb3f791708d07c82f53142
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M llvm/lib/Support/YAMLParser.cpp

  Log Message:
  -----------
  [YAMLParser] Scanner::setError - ensure we use the StringRef::iterator argument (PR45043)

As detailed on PR45043, static analysis was warning that the StringRef::iterator Position argument was being ignored and the function was hardwired to use the Current iterator.

This patch ensures we use the provided iterator and removes the (barely necessary) setError wrapper that always used Current.

Differential Revision: https://reviews.llvm.org/D76512