[all-commits] [llvm/llvm-project] 8e7b25: [NFC] Move ARM `opt -indvars` test from Codegen in...

[Roman Lebedev via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e7b25bb401ada4e1d5d026712150ab43598a79e
      https://github.com/llvm/llvm-project/commit/8e7b25bb401ada4e1d5d026712150ab43598a79e
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    R llvm/test/CodeGen/ARM/indvar-cost.ll
    R llvm/test/CodeGen/ARM/indvar-unroll-imm-cost.ll
    A llvm/test/Transforms/IndVarSimplify/ARM/indvar-cost.ll
    A llvm/test/Transforms/IndVarSimplify/ARM/indvar-unroll-imm-cost.ll
    A llvm/test/Transforms/IndVarSimplify/ARM/lit.local.cfg

  Log Message:
  -----------
  [NFC] Move ARM `opt -indvars` test from Codegen into Transforms

They are really not codegen tests.


  Commit: 7d572ef2dd9bf68d56c0fa3152c2dea2f778f147
      https://github.com/llvm/llvm-project/commit/7d572ef2dd9bf68d56c0fa3152c2dea2f778f147
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M llvm/lib/Transforms/Utils/LoopUtils.cpp
    M llvm/test/Transforms/IndVarSimplify/ARM/indvar-cost.ll
    R llvm/test/Transforms/IndVarSimplify/do-recompute-if-cheap.ll
    A llvm/test/Transforms/IndVarSimplify/dont-recompute.ll
    M llvm/test/Transforms/IndVarSimplify/elim-extend.ll
    M llvm/test/Transforms/IndVarSimplify/lrev-existing-umin.ll
    M llvm/test/Transforms/IndVarSimplify/pr28705.ll
    M llvm/test/Transforms/IndVarSimplify/pr39673.ll

  Log Message:
  -----------
  Revert "[SCEV] rewriteLoopExitValues(): even if have hard uses, still rewrite if cheap (PR44668)"

As discussed in post-commit review in https://reviews.llvm.org/D73501
if the goal of this is to help vectorizer, then we should actually
be teaching vectorizer to do this, because right now this rewrite
is still budget-limited, which isn't what we'd want.

Additionally, while the rest of the patch series was universally profitable,
this particular patch is reportedly (https://reviews.llvm.org/D73501#1905171)
exposing cost-modeling issues on ARM.

So let's just back this particular patch out. Once there's an undo transform,
this could be considered for reintegration.

This reverts commit 44edc6fd2c63b7db43e13cc8caf1fee79bebdb5f.


Compare: https://github.com/llvm/llvm-project/compare/396b1ee0e0b0...7d572ef2dd9b