[all-commits] [llvm/llvm-project] 322b53: [libc++] Attempt to fix the 'runtimes' build

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Apr 2 09:14:32 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 322b53239d4702a0f7cd63c59be2e4d5f1ee0af9
      https://github.com/llvm/llvm-project/commit/322b53239d4702a0f7cd63c59be2e4d5f1ee0af9
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M libcxx/cmake/Modules/HandleLibCXXABI.cmake

  Log Message:
  -----------
  [libc++] Attempt to fix the 'runtimes' build

The 'runtimes' build started failing because libc++ stopped using the
in-tree libc++abi when HAVE_CXXABI is set after 61e89737c. This commit
tries to bring back the old behavior when HAVE_CXXABI is set in order
to fix CIs.

However, we really need to sit down and discuss what ways of building
libc++ are supported and formalize them, because having the libc++ build
system branch on basically random variables in some CMake cache somewhere
is not a viable path forward.




More information about the All-commits mailing list