[all-commits] [llvm/llvm-project] 61e897: [libc++] Simplify the configuration of the C++ ABI...

[Louis Dionne via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 61e89737c5daf7b65341936f88f68efb680cdcd4
      https://github.com/llvm/llvm-project/commit/61e89737c5daf7b65341936f88f68efb680cdcd4
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxx/cmake/Modules/HandleLibCXXABI.cmake

  Log Message:
  -----------
  [libc++] Simplify the configuration of the C++ ABI library

This commit removes support for building against the system libc++abi,
which was supported on Apple platforms. This is basically never what we
want to do, since libc++ and libc++abi are coupled and building a trunk
libc++ against an older libc++abi can lead to incompatibilities (and
good luck debugging them!). It might have made some sense to support
that when the monorepo did not exist, however I don't think this is
anything but a footgun nowadays.

Furthermore, based on the newly-made assumption that we're building
against the monorepo libc++abi, we can simplify the search path logic
for finding libc++abi.

This area of our build system has a lot of technical debt accumulated,
and it's surprisingly difficult to change. We've tried different things
and failed several times in the past. I did test this change on our
Docker image for the build bots and on Apple platforms, however it is
possible that this breaks some unknown configuration, in which case it
should be fine to revert this (so we can try again!).