[all-commits] [llvm/llvm-project] e65e67: [globalisel][legalizer] Fix DebugLoc bugs caught b...

Daniel Sanders via All-commits all-commits at lists.llvm.org
Wed Apr 1 12:50:38 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e65e677ee4eed83a31503b1a7db3fca56f617eae
      https://github.com/llvm/llvm-project/commit/e65e677ee4eed83a31503b1a7db3fca56f617eae
  Author: Daniel Sanders <daniel_l_sanders at apple.com>
  Date:   2020-04-01 (Wed, 01 Apr 2020)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

  Log Message:
  -----------
  [globalisel][legalizer] Fix DebugLoc bugs caught by a prototype lost-location verifier

The legalizer has a tendency to lose DebugLoc's when expanding or
combining instructions. The verifier that detected these isn't ready
for upstreaming yet but this patch fixes the cases that came up when
applying it to our out-of-tree backend's CodeGen tests.

This pattern comes up a few more times in this file and probably in
the backends too but I'd prefer to fix the others separately (and
preferably when the lost-location verifier detects them).




More information about the All-commits mailing list