[all-commits] [llvm/llvm-project] a9c227: [libc++] Remove incorrect assertion in the filesys...

Louis Dionne via All-commits all-commits at lists.llvm.org
Tue Mar 31 07:07:56 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a9c22739e675ad26093a8e584ab6bbc24f6a7bb3
      https://github.com/llvm/llvm-project/commit/a9c22739e675ad26093a8e584ab6bbc24f6a7bb3
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    M libcxx/test/support/filesystem_test_helper.h

  Log Message:
  -----------
  [libc++] Remove incorrect assertion in the filesystem tests

Based on the current discussion in https://llvm.org/PR45307, it seems
that it's legitimate for `temp_directory_path()` to return a path with
a trailing slash. Since `p.parent_path()` will never contain a trailing
slash, comparing it to the result of `temp_directory_path()` will fail
depending on whether `temp_directory_path()` returns a trailing slash
or not.




More information about the All-commits mailing list