[all-commits] [llvm/llvm-project] 6aacdd: [docs] Document coding standard for error and warn...

[James Henderson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6aacdd6083d841cd4afb47ba184236844021ac46
      https://github.com/llvm/llvm-project/commit/6aacdd6083d841cd4afb47ba184236844021ac46
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    M llvm/docs/CodingStandards.rst

  Log Message:
  -----------
  [docs] Document coding standard for error and warning messages

In particular, these messages should start with a lower-case letter and
should have no trailing period at the end of the last sentence.

See http://lists.llvm.org/pipermail/llvm-dev/2020-March/140178.html for
context.

Reviewed by: aaron.ballman, hubert.reinterpretcast, rnk, dblaikie

Differential Revision: https://reviews.llvm.org/D76833


  Commit: 0aa9c5429b83df1a5881f066475e2246a02491a5
      https://github.com/llvm/llvm-project/commit/0aa9c5429b83df1a5881f066475e2246a02491a5
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    R lld/test/ELF/Inputs/deplibs-lib_bar.s
    R lld/test/ELF/Inputs/deplibs-lib_foo.s
    M lld/test/ELF/deplibs-colon-prefix.s
    M lld/test/ELF/deplibs.s

  Log Message:
  -----------
  [lld][ELF][test] Improve deplib.s

The test had a few style issues, and I noticed a hole in the coverage
(namely that the search order wasn't tested). Adding cases for the hole
in turn meant other cases weren't important.

The .so test case isn't important, since the code is shared code, so
I've removed it. Additionally, I've modified the usage of the "bar"
directive to show that an unneeded library must still be present, or the
link will fail, even though it isn't linked in.

Reviewed by: MaskRay, grimar

Differential Revision: https://reviews.llvm.org/D76851


  Commit: b4d0384a6cd7c0715f39527b8db2bc0e54add893
      https://github.com/llvm/llvm-project/commit/b4d0384a6cd7c0715f39527b8db2bc0e54add893
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    M lld/test/ELF/many-alloc-sections.s

  Log Message:
  -----------
  [ELF][test] Add test for --gc-sections + many sections

This test covers the case where --gc-sections is used when there are
many sections. In particular, it ensures that there is no adverse
interaction with common and absolute symbols.

Reviewed by: MaskRay, grimar

Differential Revision: https://reviews.llvm.org/D76003


Compare: https://github.com/llvm/llvm-project/compare/06c58f11a99a...b4d0384a6cd7