[all-commits] [llvm/llvm-project] 38ddb4: [lldb/Reproducers] Always collect the whole dSYM i...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 38ddb49e5242920e44a982cff7bbe2e86bd23a69
      https://github.com/llvm/llvm-project/commit/38ddb49e5242920e44a982cff7bbe2e86bd23a69
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    M lldb/include/lldb/Utility/Reproducer.h
    M lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
    M lldb/source/Utility/Reproducer.cpp
    A lldb/test/Shell/Reproducer/TestDSYM.test

  Log Message:
  -----------
  [lldb/Reproducers] Always collect the whole dSYM in the reproducer

The FileCollector in LLDB collects every files that's used during a
debug session when capture is enabled. This ensures that the reproducer
only contains the files necessary to reproduce. This approach is not a
good fit for the dSYM bundle, which is a directory on disk, but should
be treated as a single unit.

On macOS LLDB have automatically find the matching dSYM for a binary by
its UUID. Having a incomplete dSYM in a reproducer can break debugging
even when reproducers are disabled.

This patch adds a was to specify a directory of interest to the
reproducers. It is called from SymbolVendorMacOSX with the path of the
dSYMs used by LLDB.

Differential revision: https://reviews.llvm.org/D76672