[all-commits] [llvm/llvm-project] de77d2: [ADT] Allow empty string in StringSet

[Sam Clegg via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: de77d2312751514ce9fbf9b0bf11cbe93cd486f9
      https://github.com/llvm/llvm-project/commit/de77d2312751514ce9fbf9b0bf11cbe93cd486f9
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    M llvm/include/llvm/ADT/StringSet.h
    M llvm/unittests/ADT/StringSetTest.cpp

  Log Message:
  -----------
  [ADT] Allow empty string in StringSet

Also add a test case to wasm-ld that asserts without this change.
Internally wasm-ld builds a StringMap of exported functions and it seems
like allowing empty string in the set is preferable to adding checks.

This assert looks like it was most likely just a historical accident.
It started life here purely to support InputLanguagesSet:

  eeac27e38c5c567d63bbfa5410620d955696491b

Then got extracted here:

  e57a4033385c5976cbb17af1e962b1224a61183b

Then got moved to AST here

  5c48bae209bcbd261886f63abac695b1e30544e6

With the `InLang` paramater name still intact which suggested is
InputLanguagesSet origins.

Differential Revision: https://reviews.llvm.org/D74589