[all-commits] [llvm/llvm-project] 20eb71: lld: Reduce number of references to undefined prin...

[Nico Weber via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 20eb719f99c4979838c2995a447452f9fc3d3605
      https://github.com/llvm/llvm-project/commit/20eb719f99c4979838c2995a447452f9fc3d3605
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    M lld/COFF/SymbolTable.cpp
    M lld/ELF/Relocations.cpp
    M lld/test/COFF/undefined-symbol-multi.s
    M lld/test/ELF/undef-multi.s

  Log Message:
  -----------
  lld: Reduce number of references to undefined printed from 10 to 3.

As of a while ago, lld groups all undefined references to a single
symbol in a single diagnostic. Back then, I made it so that we
print up to 10 references to each undefined symbol.

Having used this for a while, I never wished there were more
references, but I sometimes found that this can print a lot of
output. lld prints up to 10 diagnostics by default, and if
each has 10 references (which I've seen in practice), and each
undefined symbol produces 2 (possibly very long) lines of output,
that's over 200 lines of error output.

Let's try it with just 3 references for a while and see how
that feels in practice.

Differential Revision: https://reviews.llvm.org/D77017