[all-commits] [llvm/llvm-project] 32c9ef: [libc++] Add support for a new keyword ADDITIONAL_...

Louis Dionne via All-commits all-commits at lists.llvm.org
Mon Mar 30 09:42:12 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 32c9efb423035ef7c5db6cb6e7b68ac935a8d15b
      https://github.com/llvm/llvm-project/commit/32c9efb423035ef7c5db6cb6e7b68ac935a8d15b
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    A libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
    R libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.sh.cpp
    M libcxx/test/libcxx/selftest/test.arc.fail.mm
    M libcxx/test/libcxx/selftest/test.arc.pass.mm
    M libcxx/test/libcxx/type_traits/is_pointer.arc.pass.mm
    M libcxx/utils/libcxx/test/format.py

  Log Message:
  -----------
  [libc++] Add support for a new keyword ADDITIONAL_COMPILE_FLAGS

This allows adding compilation flags for a single test, which can help
eliminate some .sh.cpp tests and some custom handling in the libc++
test format.

It also works around the issue that .sh.cpp substitutions are _not_
equivalent to the actual compiler command lines used to compile tests,
since the compiler flags can be modified in local lit configurations,
and substitutions are frozen at that point. For example using %{compile}
in a .sh.cpp test in the coroutines subdirectory will not include the
-fcoroutines-ts flag, which is added in the local lit config, because
the %{compile} substitution is created long before we add -fcoroutines-ts
to the compiler flags (in the lit.local.cfg for coroutines).




More information about the All-commits mailing list