[all-commits] [llvm/llvm-project] 378897: Revert "[lldb] Fix TestSettings.test_pass_host_env...

Pavel Labath via All-commits all-commits at lists.llvm.org
Mon Mar 30 08:32:58 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 37889786b040bd2bc48e5a01c6b92de777564a8f
      https://github.com/llvm/llvm-project/commit/37889786b040bd2bc48e5a01c6b92de777564a8f
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    M lldb/source/Host/windows/ProcessLauncherWindows.cpp
    M lldb/test/API/commands/settings/TestSettings.py

  Log Message:
  -----------
  Revert "[lldb] Fix TestSettings.test_pass_host_env_vars on windows"

This reverts commit because of test failures in TestHelloWorld.

It seems that this test (specifically running "ls" as a platform shell
command) depended on the implicit passing of the host environment.

The fix should be fairly simple (inherit the environment explicitly),
but it may take me a while to figure where exactly to do that. Revert
while I am figuring that out.




More information about the All-commits mailing list