[all-commits] [llvm/llvm-project] 908f78: [lldb] Fix TestSettings.test_pass_host_env_vars on...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 908f78f3c19805ee7386186072407a541c9fb167
      https://github.com/llvm/llvm-project/commit/908f78f3c19805ee7386186072407a541c9fb167
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    M lldb/source/Host/windows/ProcessLauncherWindows.cpp
    M lldb/test/API/commands/settings/TestSettings.py

  Log Message:
  -----------
  [lldb] Fix TestSettings.test_pass_host_env_vars on windows

Summary:
A defensive check in ProcessLauncherWindows meant that we would never
attempt to launch a process with a completely empty environment -- the
host environment would be used instead. Instead, I make the function add
an extra null wchar_t at the end of an empty environment. The
documentation on this is a bit fuzzy, but it seems to be what is needed
to make windows accept these kinds of environments.

Reviewers: amccarth, friss

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D76835