[all-commits] [llvm/llvm-project] 853a1e: Only add `darwin_log_cmd` lit shell test feature w...

danliew via All-commits all-commits at lists.llvm.org
Fri Mar 27 11:26:17 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 853a1e6942c824775cff20142301f9b114853b0f
      https://github.com/llvm/llvm-project/commit/853a1e6942c824775cff20142301f9b114853b0f
  Author: Dan Liew <dan at su-root.co.uk>
  Date:   2020-03-27 (Fri, 27 Mar 2020)

  Changed paths:
    M compiler-rt/test/lit.common.cfg.py

  Log Message:
  -----------
  Only add `darwin_log_cmd` lit shell test feature when the log can be queried.

Summary:
Follow up fix to 445b810fbd4. The `log show` command only works for
privileged users so run a quick test of the command during lit config to
see if the command works and only add the `darwin_log_cmd` feature if
this is the case.

Unfortunately this means the `asan/TestCases/Darwin/duplicate_os_log_reports.cpp`
test and any other tests in the future that use this feature won't run
for unprivileged users which is likely the case in CI.

rdar://problem/55986279

Reviewers: kubamracek, yln, dcoughlin

Subscribers: Charusso, #sanitizers, llvm-commits

Tags: #sanitizers

Differential Revision: https://reviews.llvm.org/D76899




More information about the All-commits mailing list