[all-commits] [llvm/llvm-project] a5fa5f: [libc++] Do not force the use of -Werror in verify...

[Louis Dionne via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a5fa5f7cb86c8c271e628f49454cf6d27ba7b11f
      https://github.com/llvm/llvm-project/commit/a5fa5f7cb86c8c271e628f49454cf6d27ba7b11f
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-03-26 (Thu, 26 Mar 2020)

  Changed paths:
    M libcxx/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.depr_in_cxx14.fail.cpp
    M libcxx/test/libcxx/depr/depr.auto.ptr/auto.ptr/auto_ptr.depr_in_cxx11.fail.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/address.depr_in_cxx17.fail.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.cxx2a.fail.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.depr_in_cxx17.fail.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator_types.depr_in_cxx17.fail.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator_void.depr_in_cxx17.fail.cpp
    M libcxx/test/libcxx/depr/depr.function.objects/adaptors.depr_in_cxx11.fail.cpp
    M libcxx/test/libcxx/diagnostics/enable_nodiscard.fail.cpp
    M libcxx/test/libcxx/diagnostics/enable_nodiscard_disable_after_cxx17.fail.cpp
    M libcxx/test/libcxx/diagnostics/enable_nodiscard_disable_nodiscard_ext.fail.cpp
    M libcxx/test/libcxx/diagnostics/nodiscard_aftercxx17.fail.cpp
    M libcxx/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp
    M libcxx/test/libcxx/experimental/filesystem/deprecated.fail.cpp
    M libcxx/test/libcxx/thread/thread.lock/thread.lock.guard/nodiscard.fail.cpp
    M libcxx/test/libcxx/utilities/function.objects/func.wrap/depr_in_cxx03.fail.cpp
    M libcxx/test/std/containers/associative/map/map.access/empty.fail.cpp
    M libcxx/test/std/containers/associative/multimap/empty.fail.cpp
    M libcxx/test/std/containers/associative/multiset/empty.fail.cpp
    M libcxx/test/std/containers/associative/set/empty.fail.cpp
    M libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.members/empty.fail.cpp
    M libcxx/test/std/containers/container.adaptors/queue/queue.defn/empty.fail.cpp
    M libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.fail.cpp
    M libcxx/test/std/containers/sequences/array/array.creation/to_array.fail.cpp
    M libcxx/test/std/containers/sequences/array/empty.fail.cpp
    M libcxx/test/std/containers/sequences/deque/deque.capacity/empty.fail.cpp
    M libcxx/test/std/containers/sequences/forwardlist/empty.fail.cpp
    M libcxx/test/std/containers/sequences/list/list.capacity/empty.fail.cpp
    M libcxx/test/std/containers/sequences/vector.bool/empty.fail.cpp
    M libcxx/test/std/containers/sequences/vector/vector.capacity/empty.fail.cpp
    M libcxx/test/std/containers/unord/unord.map/empty.fail.cpp
    M libcxx/test/std/containers/unord/unord.multimap/empty.fail.cpp
    M libcxx/test/std/containers/unord/unord.multiset/empty.fail.cpp
    M libcxx/test/std/containers/unord/unord.set/empty.fail.cpp
    M libcxx/test/std/depr/depr.lib.binders/depr.lib.bind.1st/bind1st.depr_in_cxx11.fail.cpp
    M libcxx/test/std/depr/depr.lib.binders/depr.lib.bind.2nd/bind2nd.depr_in_cxx11.fail.cpp
    M libcxx/test/std/depr/depr.lib.binders/depr.lib.binder.1st/binder1st.depr_in_cxx11.fail.cpp
    M libcxx/test/std/depr/depr.lib.binders/depr.lib.binder.2nd/binder2nd.depr_in_cxx11.fail.cpp
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.decompose/empty.fail.cpp
    M libcxx/test/std/iterators/iterator.container/empty.array.fail.cpp
    M libcxx/test/std/iterators/iterator.container/empty.container.fail.cpp
    M libcxx/test/std/iterators/iterator.container/empty.initializer_list.fail.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_array_ptr.fail.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_ptr.fail.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size.fail.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_nothrow.fail.cpp
    M libcxx/test/std/language.support/support.dynamic/ptr.launder/launder.nodiscard.fail.cpp
    M libcxx/test/std/numerics/c.math/abs.fail.cpp
    M libcxx/test/std/re/re.results/re.results.size/empty.fail.cpp
    M libcxx/test/std/strings/basic.string/string.capacity/empty.fail.cpp
    M libcxx/test/std/strings/string.view/string.view.capacity/empty.fail.cpp
    M libcxx/test/std/thread/futures/futures.async/async.fail.cpp
    M libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.members/allocate_size.fail.cpp
    M libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.members/allocate_size_hint.fail.cpp
    M libcxx/test/std/utilities/function.objects/negators/binary_negate.depr_in_cxx17.fail.cpp
    M libcxx/test/std/utilities/function.objects/negators/not1.depr_in_cxx17.fail.cpp
    M libcxx/test/std/utilities/function.objects/negators/not2.depr_in_cxx17.fail.cpp
    M libcxx/test/std/utilities/function.objects/negators/unary_negate.depr_in_cxx17.fail.cpp
    M libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/allocate.fail.cpp
    M libcxx/test/std/utilities/memory/default.allocator/allocator.members/allocate.fail.cpp
    M libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.fail.cpp
    M libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.modifiers/reset.runtime.fail.cpp
    M libcxx/utils/libcxx/test/format.py

  Log Message:
  -----------
  [libc++] Do not force the use of -Werror in verify tests

Forcing -Werror and other warnings means that the test suite isn't
actually testing what most people are seeing in their code -- it seems
better and less arbitrary to compile these tests as close as possible
to the compiler default instead.

Removing -Werror also means that we get to differentiate between
diagnostics that are errors and those that are warnings, which makes
the test suite more precise.

Differential Revision: https://reviews.llvm.org/D76311