[all-commits] [llvm/llvm-project] c72675: [lldb] add lit.local.cfg for breakpad tests

Pavel Labath via All-commits all-commits at lists.llvm.org
Wed Mar 25 09:00:53 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c72675394a8592dbe9733c6eef305d094f7f8119
      https://github.com/llvm/llvm-project/commit/c72675394a8592dbe9733c6eef305d094f7f8119
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-25 (Wed, 25 Mar 2020)

  Changed paths:
    M lldb/test/Shell/SymbolFile/Breakpad/Inputs/unwind-via-raSearch.syms
    M lldb/test/Shell/SymbolFile/Breakpad/Inputs/unwind-via-stack-win.syms
    M lldb/test/Shell/SymbolFile/Breakpad/Inputs/unwind-via-stack-win.yaml
    A lldb/test/Shell/SymbolFile/Breakpad/lit.local.cfg
    M lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test
    M lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml
    M lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win.test

  Log Message:
  -----------
  [lldb] add lit.local.cfg for breakpad tests

The reason is to add .yaml as a valid test suffix. The test folder
contains one yaml file, which wasn't being run because of that.

Unsurprisingly the test fails, but this was not because the underlying
functionality was broken, but rather because the test was setup
incorrectly (most likely due to overly aggressive simplification of the
test data on my part).

Therefore this patch also tweaks the test inputs in order to test what
they are supposed to test, and also updates some other breakpad tests
(because they depend on the same inputs as this one) to be more
realistic -- specifically it avoids putting symbols to the first page of
the module, as that's where normally the COFF header would reside.




More information about the All-commits mailing list