[all-commits] [llvm/llvm-project] 0ccc4d: [lldb] Always log if acquiring packet sequence mut...
    Raphael Isemann via All-commits 
    all-commits at lists.llvm.org
       
    Tue Mar 24 12:25:03 PDT 2020
    
    
  
  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ccc4de42eae92d5a7a1b67b29d7921c7f144b8d
      https://github.com/llvm/llvm-project/commit/0ccc4de42eae92d5a7a1b67b29d7921c7f144b8d
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-03-24 (Tue, 24 Mar 2020)
  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  Log Message:
  -----------
  [lldb] Always log if acquiring packet sequence mutex fails
Summary:
Currently we only log in debug builds but I don't see why we would do this as this is neither
expensive and seems useful.
I looked into the git history of this code and it seems originally there was also an assert here
and the logging here was the #else branch branch for non-Debug builds.
Reviewers: #lldb, labath
Reviewed By: labath
Subscribers: JDevlieghere
Differential Revision: https://reviews.llvm.org/D76698
    
    
More information about the All-commits
mailing list