[all-commits] [llvm/llvm-project] 5896e2: [Clang] Fix HIP tests when running on Windows with...

[Alexandre Ganea via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5896e2df45dab7680be321ee63903431a673817b
      https://github.com/llvm/llvm-project/commit/5896e2df45dab7680be321ee63903431a673817b
  Author: Alexandre Ganea <alexandre.ganea at ubisoft.com>
  Date:   2020-03-23 (Mon, 23 Mar 2020)

  Changed paths:
    M clang/test/Driver/hip-device-compile.hip
    M clang/test/Driver/hip-toolchain-no-rdc.hip
    M clang/test/Driver/hip-toolchain-rdc.hip

  Log Message:
  -----------
  [Clang] Fix HIP tests when running on Windows with the LLVM toolchain is in the path

On Windows, when the LLVM toolchain is in the current path (%PATH%), fusing the linker yields c:\{path}\lld.exe whereas the hip tests did not expect the .exe part.
This only happens if LLD is not present in the build folder, which consequently makes the code in Driver::GetProgramPath() to fall back to %PATH% and platform-specific search, which includes the .exe part (see https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/Driver.cpp#L4733).

Differential Revision: https://reviews.llvm.org/D76631