[all-commits] [llvm/llvm-project] 67d67e: Internal expressions shouldn't increment the resul...

[jimingham via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 67d67ebe8f2535c5de75c62820f7713f87d07307
      https://github.com/llvm/llvm-project/commit/67d67ebe8f2535c5de75c62820f7713f87d07307
  Author: Jim Ingham <jingham at apple.com>
  Date:   2020-03-23 (Mon, 23 Mar 2020)

  Changed paths:
    M lldb/include/lldb/Expression/ExpressionVariable.h
    M lldb/include/lldb/Target/Target.h
    M lldb/source/Core/ValueObject.cpp
    M lldb/source/Expression/ExpressionVariable.cpp
    M lldb/source/Expression/Materializer.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
    M lldb/source/Target/ABI.cpp
    A lldb/test/API/commands/expression/result_numbering/Makefile
    A lldb/test/API/commands/expression/result_numbering/TestResultNumbering.py
    A lldb/test/API/commands/expression/result_numbering/main.c

  Log Message:
  -----------
  Internal expressions shouldn't increment the result variable numbering.

There an option: EvaluateExpressionOptions::SetResultIsInternal to indicate
whether the result number should be returned to the pool or not.  It
got broken when the PersistentExpressionState was refactored.

This fixes the issue and provides a test of the behavior.

Differential Revision: https://reviews.llvm.org/D76532