[all-commits] [llvm/llvm-project] f4c67d: [X86] More accurately model the cost of horizontal...

[topperc via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f4c67dfa925a6735fb31edf9d06f4a8e6e1cc812
      https://github.com/llvm/llvm-project/commit/f4c67dfa925a6735fb31edf9d06f4a8e6e1cc812
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-03-22 (Sun, 22 Mar 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86TargetTransformInfo.cpp
    M llvm/test/Analysis/CostModel/X86/reduce-add.ll
    M llvm/test/Analysis/CostModel/X86/reduce-and.ll
    M llvm/test/Analysis/CostModel/X86/reduce-mul.ll
    M llvm/test/Analysis/CostModel/X86/reduce-or.ll
    M llvm/test/Analysis/CostModel/X86/reduce-xor.ll
    M llvm/test/Analysis/CostModel/X86/reduction.ll
    M llvm/test/Transforms/SLPVectorizer/X86/reduction_unrolled.ll

  Log Message:
  -----------
  [X86] More accurately model the cost of horizontal reductions.

This patch attempts to more accurately model the reduction of
power of 2 vectors of types we natively support. This takes into
account the narrowing of vectors that occur as we go from 512
bits to 256 bits, to 128 bits. It also takes into account the use
of wider elements in the shuffles for the first 2 steps of a
reduction from 128 bits. And uses a v8i16 shift for the final step
of vXi8 reduction.

The default implementation uses the legalized type for the arithmetic
for all levels. And uses the single source permute cost of the
legalized type for all levels. This penalizes things like
lack of v16i8 pshufb on pre-sse3 targets and the splitting and
joining that needs to be done for integer types on AVX1. We never
need v16i8 shuffle for a reduction and we only need split AVX1 ops
when type the type wide and needs to be split. I think we're still
over costing splits and joins for AVX1, but we're closer now.

I've also removed all pairwise special casing because I don't
think we ever want to generate that on X86. I've also adjusted
the add handling to more accurately account for any type splitting
that occurs before we reach a legal type.

Differential Revision: https://reviews.llvm.org/D76478