[all-commits] [llvm/llvm-project] dc8192: [InstCombine] Remove ExpensiveCombines option

Nikita Popov via All-commits all-commits at lists.llvm.org
Sun Mar 22 08:58:54 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dc81923659c26f21821aaad215ac251034566faa
      https://github.com/llvm/llvm-project/commit/dc81923659c26f21821aaad215ac251034566faa
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2020-03-22 (Sun, 22 Mar 2020)

  Changed paths:
    M llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
    M llvm/include/llvm/Transforms/InstCombine/InstCombine.h
    M llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
    M llvm/lib/Transforms/InstCombine/InstCombineInternal.h
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/test/Transforms/InstCombine/all-bits-shift.ll
    M llvm/test/Transforms/InstCombine/assume.ll
    M llvm/test/Transforms/InstCombine/call-returned.ll
    R llvm/test/Transforms/InstCombine/expensive-combines.ll
    M llvm/test/Transforms/InstCombine/known-bits.ll
    M llvm/test/Transforms/InstCombine/known-signbit-shift.ll
    M llvm/test/Transforms/InstCombine/out-of-bounds-indexes.ll
    M llvm/test/Transforms/InstCombine/phi-shifts.ll
    M llvm/test/Transforms/InstCombine/pr44541.ll

  Log Message:
  -----------
  [InstCombine] Remove ExpensiveCombines option

D75801 removed the last and only user of this option, so we can
drop it now. The original idea behind this was to only run expensive
transforms under -O3, but apart from the one known bits transform,
this has never really taken off. I believe nowadays the recommendation
is to put expensive transforms in AggressiveInstCombine instead,
though that isn't terribly popular either :)

Differential Revision: https://reviews.llvm.org/D76540




More information about the All-commits mailing list