[all-commits] [llvm/llvm-project] b5eafd: Revert "EHScopeStack::Cleanup has virtual function...

David Blaikie via All-commits all-commits at lists.llvm.org
Sat Mar 21 21:18:19 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b5eafda8d3ef02f9f78e090725564dd28e573322
      https://github.com/llvm/llvm-project/commit/b5eafda8d3ef02f9f78e090725564dd28e573322
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-03-21 (Sat, 21 Mar 2020)

  Changed paths:
    M clang/lib/CodeGen/EHScopeStack.h

  Log Message:
  -----------
  Revert "EHScopeStack::Cleanup has virtual functions so the destructor should be too."

This type was already well designed - having a protected destructor, and
derived classes being final/public non-virtual destructors, the type
couldn't be destroyed polymorphically & accidentally cause slicing.

This reverts commit 736385c0b49d42f398ffa1458883f0d182178ef4.




More information about the All-commits mailing list