[all-commits] [llvm/llvm-project] a8c22b: [lldb-vscode] Add missing launchCommands entry in ...

[walter erquinigo via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a8c22ba4162976894b34b75fd12aced379e0569b
      https://github.com/llvm/llvm-project/commit/a8c22ba4162976894b34b75fd12aced379e0569b
  Author: Walter Erquinigo <waltermelon at fb.com>
  Date:   2020-03-20 (Fri, 20 Mar 2020)

  Changed paths:
    M lldb/tools/lldb-vscode/package.json

  Log Message:
  -----------
  [lldb-vscode] Add missing launchCommands entry in the package.json

Summary:
https://reviews.llvm.org/D65363 introduced the launchCommands argument. However, it did not add
a corresponding definition in the package.json

Reviewers: clayborg, labath, kusmour, aadsm

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D76529


  Commit: 4ec6ebabfc3ec03d3ad4d3bdf05a7292d01391b3
      https://github.com/llvm/llvm-project/commit/4ec6ebabfc3ec03d3ad4d3bdf05a7292d01391b3
  Author: Hector Diaz <hdiaz at fb.com>
  Date:   2020-03-20 (Fri, 20 Mar 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
    A lldb/test/API/tools/lldb-vscode/environmentVariables/Makefile
    A lldb/test/API/tools/lldb-vscode/environmentVariables/TestVSCode_environmentVariables.py
    A lldb/test/API/tools/lldb-vscode/environmentVariables/main.cpp
    M lldb/tools/lldb-vscode/lldb-vscode.cpp
    M lldb/tools/lldb-vscode/package.json

  Log Message:
  -----------
  [lldb-vscode] Add inheritEnvironment option

Summary:
If no custom launching is used, lldb-vscode launches a program with an empty environment by default. In some scenarios, the user might want to simply use the same environment as the IDE to have a set of working environment variables (e.g. PATH wouldn't be empty). In fact, most DAPs in VSCode have this behavior by default. In other cases the user definitely needs to set their custom environment, which is already supported. To make the first case easier for the user (e.g. not having to copy the PATH to the launch.json every time they want to debug simple programs that rely on PATH), a new option is now offered. inheritEnvironment will launch the program copying its own environment, and it's just a boolean flag.

{F11347695}

Reviewers: clayborg, aadsm, diazhector98, kusmour

Subscribers: labath, JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D74636


  Commit: 34c0759f846447454714c8faa0e1753a8713637b
      https://github.com/llvm/llvm-project/commit/34c0759f846447454714c8faa0e1753a8713637b
  Author: Walter Erquinigo <waltermelon at fb.com>
  Date:   2020-03-20 (Fri, 20 Mar 2020)

  Changed paths:
    M lldb/bindings/headers.swig
    A lldb/bindings/interface/SBEnvironment.i
    M lldb/bindings/interface/SBLaunchInfo.i
    M lldb/bindings/interface/SBPlatform.i
    M lldb/bindings/interface/SBTarget.i
    M lldb/bindings/interfaces.swig
    M lldb/include/lldb/API/LLDB.h
    M lldb/include/lldb/API/SBDefines.h
    A lldb/include/lldb/API/SBEnvironment.h
    M lldb/include/lldb/API/SBLaunchInfo.h
    M lldb/include/lldb/API/SBPlatform.h
    M lldb/include/lldb/API/SBTarget.h
    M lldb/include/lldb/Utility/Environment.h
    M lldb/include/lldb/lldb-forward.h
    M lldb/source/API/CMakeLists.txt
    A lldb/source/API/SBEnvironment.cpp
    M lldb/source/API/SBLaunchInfo.cpp
    M lldb/source/API/SBPlatform.cpp
    M lldb/source/API/SBTarget.cpp
    A lldb/test/API/python_api/sbenvironment/TestSBEnvironment.py

  Log Message:
  -----------
  Create basic SBEnvironment class

Summary: Inspired by https://reviews.llvm.org/D74636, I'm introducing a basic version of Environment in the API. More functionalities can be added as needed.

Reviewers: labath, clayborg

Subscribers: mgorny, lldb-commits, diazhector98

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D76111


Compare: https://github.com/llvm/llvm-project/compare/a299178ae77a...34c0759f8464