[all-commits] [llvm/llvm-project] ce5173: Use FinishThunk to finish musttail thunks

[Reid Kleckner via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ce5173c0e174870934d1b3a026f631d996136191
      https://github.com/llvm/llvm-project/commit/ce5173c0e174870934d1b3a026f631d996136191
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-03-20 (Fri, 20 Mar 2020)

  Changed paths:
    M clang/lib/CodeGen/CGVTables.cpp
    A clang/test/CodeGenCXX/ms-thunks-ehspec.cpp
    A clang/test/CodeGenCXX/thunks-ehspec.cpp

  Log Message:
  -----------
  Use FinishThunk to finish musttail thunks

FinishThunk, and the invariant of setting and then unsetting
CurCodeDecl, was added in 7f416cc42638 (2015). The invariant didn't
exist when I added this musttail codepath in ab2090d10765 (2014).
Recently in 28328c3771, I started using this codepath on non-Windows
platforms, and users reported problems during release testing (PR44987).

The issue was already present for users of EH on i686-windows-msvc, so I
added a test for that case as well.

Reviewed By: hans

Differential Revision: https://reviews.llvm.org/D76444