[all-commits] [llvm/llvm-project] 1c1537: Recommit: CFGDiff: Simplify/common the begin/end i...

[David Blaikie via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c1537749615a9be98a33482cdf6bf6f602f1eed
      https://github.com/llvm/llvm-project/commit/1c1537749615a9be98a33482cdf6bf6f602f1eed
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-03-19 (Thu, 19 Mar 2020)

  Changed paths:
    M llvm/include/llvm/IR/CFGDiff.h

  Log Message:
  -----------
  Recommit: CFGDiff: Simplify/common the begin/end implementations to use a common range helper""

(would be nice to revisit the CFG traits and change them to use ranges
rather than begin/end - if anyone wants to do that refactor)

Also use more auto because writing the names of range utilty iterators
isn't helping readability here - they're sort of implementation details
for the most part, especially once you nest a few different filtering
and adapting iterators.

The fix (shooting from the hip since I couldn't reproduce this locally)
was to capture by value in a lambda used in a filtering iterator -
because the iterator would persist beyond the lifetime of the function
(as the iterators are returned to callers).

Originally committed in 79a7ed92a9b135212a6a271dd8dbc625038c8f06.
This was reverted in 4a7f2032a350bc7eefd26709563f65216df3e2ce.