[all-commits] [llvm/llvm-project] e26e9b: [obj2yaml] - Stop dumping an empty sh_info field f...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Thu Mar 19 04:00:34 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e26e9ba288ce156b851504ebbb7d8a775572957c
      https://github.com/llvm/llvm-project/commit/e26e9ba288ce156b851504ebbb7d8a775572957c
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-03-19 (Thu, 19 Mar 2020)

  Changed paths:
    R llvm/test/tools/obj2yaml/elf-reladyn-section-shinfo.yaml
    A llvm/test/tools/obj2yaml/rel-rela-section.yaml
    M llvm/tools/obj2yaml/elf2yaml.cpp

  Log Message:
  -----------
  [obj2yaml] - Stop dumping an empty sh_info field for SHT_RELA/SHT_REL sections.

`.rela.dyn` is a dynamic relocation section that normally has
no value in `sh_info` field.

The existent `elf-reladyn-section-shinfo.yaml` which tests this piece has issues:

1) It does not check the case when we have more than one `SHT_REL[A]`
   section with `sh_info == 0` in the object. Because of this it did not catch the issue.
   Currently we print an excessive "Info" field:

```
  - Name:            .rela.dyn
    Type:            SHT_RELA
    EntSize:         0x0000000000000018
  - Name:            .rel.dyn
    Type:            SHT_REL
    EntSize:         0x0000000000000010
    Info:            ' [1]'
```

2) It seems can be more generic. I've added a `rel-rela-section.yaml` instead.

Differential revision: https://reviews.llvm.org/D76281




More information about the All-commits mailing list