[all-commits] [llvm/llvm-project] 585a3c: Fix -Wdeprecated-copy-dtor and -Wdeprecated-dynami...

[Dimitry Andric via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 585a3cc31bb49f2a526dcb74dc9a980379193f93
      https://github.com/llvm/llvm-project/commit/585a3cc31bb49f2a526dcb74dc9a980379193f93
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M libcxx/include/codecvt
    M libcxx/include/exception
    M libcxx/include/filesystem
    M libcxx/include/future
    M libcxx/include/ios
    M libcxx/include/memory
    M libcxx/include/regex
    M libcxx/include/stdexcept
    M libcxx/include/system_error
    M libcxx/include/typeinfo

  Log Message:
  -----------
  Fix -Wdeprecated-copy-dtor and -Wdeprecated-dynamic-exception-spec warnings.

Summary:
The former are like:

libcxx/include/typeinfo:322:11: warning: definition of implicit copy constructor for 'bad_cast' is deprecated because it has a user-declared destructor [-Wdeprecated-copy-dtor]
  virtual ~bad_cast() _NOEXCEPT;
          ^
libcxx/include/typeinfo:344:11: note: in implicit copy constructor for 'std::bad_cast' first required here
    throw bad_cast();
          ^

Fix these by adding an explicitly defaulted copy constructor.

The latter are like:

libcxx/include/codecvt:105:37: warning: dynamic exception specifications are deprecated [-Wdeprecated-dynamic-exception-spec]
    virtual int do_encoding() const throw();
                                    ^~~~~~~

Fix these by using the _NOEXCEPT macro instead.

Reviewers: EricWF, mclow.lists, ldionne, #libc

Reviewed By: EricWF, #libc

Subscribers: dexonsmith, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D76150