[all-commits] [llvm/llvm-project] 34b8a0: [Verifier] Silence static analyzer null dereferenc...

[Simon Pilgrim via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 34b8a0d5998ce9131d50e79b54ddd3e6d7d212fa
      https://github.com/llvm/llvm-project/commit/34b8a0d5998ce9131d50e79b54ddd3e6d7d212fa
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M llvm/lib/IR/Verifier.cpp

  Log Message:
  -----------
  [Verifier] Silence static analyzer null dereference warning (PR45118)

As discussed on PR45118, getInlinedAtScope() shouldn't ever return null. So we can simplify the logic to an assertion and remove all other null tests.


  Commit: c9656a3b311d5efa4faa84d4b94f873a0abf8adc
      https://github.com/llvm/llvm-project/commit/c9656a3b311d5efa4faa84d4b94f873a0abf8adc
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [DAGCombiner] matchRotateSub - handle shift amount truncation

Under certain circumstances we'll end up in the position where the negated shift amount will get truncated to the type specified getScalarShiftAmountTy(), so we need to test for a truncated version of the shift amount as well.

This allows us to remove half of the remaining patterns tested for by X86ISelLowering's combineOrShiftToFunnelShift.


Compare: https://github.com/llvm/llvm-project/compare/9cd8db1c80c2...c9656a3b311d