[all-commits] [llvm/llvm-project] 88fbd8: [lldb/Reproducers] Decode run-length encoding in G...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 88fbd8f9e79096da4d013f826fc8b4f0eea1ef66
      https://github.com/llvm/llvm-project/commit/88fbd8f9e79096da4d013f826fc8b4f0eea1ef66
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-03-16 (Mon, 16 Mar 2020)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationReplayServer.cpp
    M lldb/test/API/functionalities/reproducers/attach/TestReproducerAttach.py

  Log Message:
  -----------
  [lldb/Reproducers] Decode run-length encoding in GDB replay server.

The GDB replay server sanity-checks that every packet it receives
matches what it expects from the serialized packet log. This mechanism
tripped for TestReproducerAttach.py on Linux, because one of the packets
(jModulesInfo) uses run-length encoding. The replay server was comparing
the expanded incoming packet with the unexpanded packet in the log. As a
result, it claimed to have received an unexpected packet, which caused
the test to fail.

This patch addresses that issue by expanding the run-length encoding
before comparing the packets.

Differential revision: https://reviews.llvm.org/D76163