[all-commits] [llvm/llvm-project] 810593: [TypeSize] Allow returning scalable size in implic...

sdesmalen-arm via All-commits all-commits at lists.llvm.org
Sun Mar 15 07:11:32 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8105935d3aa98089f24b356ae782771d024d9174
      https://github.com/llvm/llvm-project/commit/8105935d3aa98089f24b356ae782771d024d9174
  Author: Sander de Smalen <sander.desmalen at arm.com>
  Date:   2020-03-15 (Sun, 15 Mar 2020)

  Changed paths:
    M llvm/CMakeLists.txt
    M llvm/cmake/modules/HandleLLVMOptions.cmake
    M llvm/include/llvm/Support/TypeSize.h
    M llvm/lib/Target/AMDGPU/AMDGPULibFunc.cpp

  Log Message:
  -----------
  [TypeSize] Allow returning scalable size in implicit conversion to uint64_t

This patch removes compiler runtime assertions that ensure the implicit
conversion are only guaranteed to work for fixed-width vectors.

With the assert it would be impossible to get _anything_ to build until
the
entire codebase has been upgraded, even when the indiscriminate uses of
the size as uint64_t would work fine for both scalable and fixed-width
types.

This issue will need to be addressed differently, with build-time errors
rather than assertion failures, but that effort falls beyond the scope
of this patch.

Returning the scalable size and avoiding the assert in getFixedSize()
is a temporary stop-gap in order to use LLVM for compiling and using
the SVE ACLE intrinsics.

Reviewers: efriedma, huntergr, rovka, ctetreau, rengolin

Reviewed By: efriedma

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D75297




More information about the All-commits mailing list