[all-commits] [llvm/llvm-project] 04410c: [clang-tidy] extend bugprone-signed-char-misuse ch...

[Tamás Zolnai via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 04410c565aa08b703ef5d11b454e7fba47163e3c
      https://github.com/llvm/llvm-project/commit/04410c565aa08b703ef5d11b454e7fba47163e3c
  Author: Tamás Zolnai <tamas.zolnai at collabora.com>
  Date:   2020-03-14 (Sat, 14 Mar 2020)

  Changed paths:
    M clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h
    M clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst
    M clang-tools-extra/test/clang-tidy/checkers/bugprone-signed-char-misuse.cpp

  Log Message:
  -----------
  [clang-tidy] extend bugprone-signed-char-misuse check.

Summary:
Cover a new use case when using a 'signed char' as an integer
might lead to issue with non-ASCII characters. Comparing
a 'signed char' with an 'unsigned char' using equality / unequality
operator produces an unexpected result for non-ASCII characters.

Reviewers: aaron.ballman, alexfh, hokein, njames93

Reviewed By: njames93

Subscribers: xazax.hun, cfe-commits

Tags: #clang, #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D75749