[all-commits] [llvm/llvm-project] d184d0: [libcxx] Enable C++17 for the benchmarks.

mordante via All-commits all-commits at lists.llvm.org
Thu Mar 12 13:35:17 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d184d0226301d8bb8b3fdaee52bb636faddd81bc
      https://github.com/llvm/llvm-project/commit/d184d0226301d8bb8b3fdaee52bb636faddd81bc
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2020-03-12 (Thu, 12 Mar 2020)

  Changed paths:
    M libcxx/benchmarks/CMakeLists.txt

  Log Message:
  -----------
  [libcxx] Enable C++17 for the benchmarks.

The benchmarks are intended to be build with C++17 but the
CMAKE_CXX_STANDARD in the LLVM forces the build to use C++14 by default.
This fixes the issue by setting the CXX_STANDARD property of the benchmark
targets.

The CMake documentation is not clear whether this will use the C++1z
fallback for older compilers. So this may break the benchmarks if somebody
uses the benchmarks with pre C++17 compilers with the C++1z fallback.

Differential Revision: https://reviews.llvm.org/D75955




More information about the All-commits mailing list