[all-commits] [llvm/llvm-project] f6790a: Revert "[MLIR] Add `and`, `or`, `xor`, `min`, `max...

Valentin Clement (バレンタイン クレメン) via All-commits all-commits at lists.llvm.org
Wed Mar 11 06:07:39 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f6790a1c63598e9e55608d60d0f4c0a1b1be8ae9
      https://github.com/llvm/llvm-project/commit/f6790a1c63598e9e55608d60d0f4c0a1b1be8ae9
  Author: Stephan Herhut <herhut at google.com>
  Date:   2020-03-11 (Wed, 11 Mar 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/GPU/GPUOps.td
    M mlir/include/mlir/ExecutionEngine/RunnerUtils.h
    M mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/lib/Dialect/GPU/Transforms/AllReduceLowering.cpp
    M mlir/lib/ExecutionEngine/RunnerUtils.cpp
    R mlir/test/Dialect/GPU/all-reduce-max.mlir
    M mlir/test/Dialect/GPU/invalid.mlir
    R mlir/test/mlir-cuda-runner/all-reduce-and.mlir
    R mlir/test/mlir-cuda-runner/all-reduce-max.mlir
    R mlir/test/mlir-cuda-runner/all-reduce-min.mlir
    R mlir/test/mlir-cuda-runner/all-reduce-or.mlir
    R mlir/test/mlir-cuda-runner/all-reduce-xor.mlir

  Log Message:
  -----------
  Revert "[MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm lowering"

Attribution to original author got lost.


  Commit: c7380995f8123558e0ac252d141d846fb97a869a
      https://github.com/llvm/llvm-project/commit/c7380995f8123558e0ac252d141d846fb97a869a
  Author: Valentin Clement <clementval at gmail.com>
  Date:   2020-03-11 (Wed, 11 Mar 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/GPU/GPUOps.td
    M mlir/include/mlir/ExecutionEngine/RunnerUtils.h
    M mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/lib/Dialect/GPU/Transforms/AllReduceLowering.cpp
    M mlir/lib/ExecutionEngine/RunnerUtils.cpp
    A mlir/test/Dialect/GPU/all-reduce-max.mlir
    M mlir/test/Dialect/GPU/invalid.mlir
    A mlir/test/mlir-cuda-runner/all-reduce-and.mlir
    A mlir/test/mlir-cuda-runner/all-reduce-max.mlir
    A mlir/test/mlir-cuda-runner/all-reduce-min.mlir
    A mlir/test/mlir-cuda-runner/all-reduce-or.mlir
    A mlir/test/mlir-cuda-runner/all-reduce-xor.mlir

  Log Message:
  -----------
  [MLIR] Add `and`, `or`, `xor`, `min`, `max` too gpu.all_reduce and the nvvm lowering

Summary:
This patch add some builtin operation for the gpu.all_reduce ops.
- for Integer only: `and`, `or`, `xor`
- for Float and Integer: `min`, `max`

This is useful for higher level dialect like OpenACC or OpenMP that can lower to the GPU dialect.

Differential Revision: https://reviews.llvm.org/D75766


Compare: https://github.com/llvm/llvm-project/compare/1fb9c29833ab...c7380995f812


More information about the All-commits mailing list