[all-commits] [llvm/llvm-project] bb0ec1: [x86][slh][NFC] Rm redundant liveness check

[George Burgess IV via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bb0ec1daff1b0eee4936878749365e625e71182c
      https://github.com/llvm/llvm-project/commit/bb0ec1daff1b0eee4936878749365e625e71182c
  Author: George Burgess IV <george.burgess.iv at gmail.com>
  Date:   2020-03-09 (Mon, 09 Mar 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp

  Log Message:
  -----------
  [x86][slh][NFC] Rm redundant liveness check

Patch by Zola Bridges!

>From the review:

"""
In this changeset (https://reviews.llvm.org/D70283), I added a liveness
check everywhere the isDataInvariant* functions were used, so that I
could safely delete the checks within the function. I mistakenly left
that deletion out of the patch. The result is that the same condition is
checked twice for some instructions which is functionally fine, but not
good. This change deletes the redundant check that I intended to delete
in the last change.

This is the second of three patches that will make the data invariance
checks available for non-SLH passes and enable the FIXMEs related to
moving this metadata to the instruction tables to be resolved.

Tested via llvm-lit llvm/test/CodeGen/X86/speculative-load-hardening*
"""

Differential Revision: https://reviews.llvm.org/D75650


  Commit: 174c3eb69f19ff2d6a3eeae31d04afe77e62c021
      https://github.com/llvm/llvm-project/commit/174c3eb69f19ff2d6a3eeae31d04afe77e62c021
  Author: George Burgess IV <george.burgess.iv at gmail.com>
  Date:   2020-03-09 (Mon, 09 Mar 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86InstrInfo.cpp
    M llvm/lib/Target/X86/X86InstrInfo.h
    M llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp

  Log Message:
  -----------
  [x86][slh] Move isDataInvariant* functions

Patch by Zola Bridges!

>From the review:

"""
I moved these functions to X86InstrInfo.cpp, so they are available from
another pass. In addition, this is a step toward resolving the FIXME to
move this metadata to the instruction tables.

This is the final step to make these two data invariance checks
available for non-SLH passes.

The other two steps were here:

- https://reviews.llvm.org/D70283
- https://reviews.llvm.org/D75650

Tested via llvm-lit llvm/test/CodeGen/X86/speculative-load-hardening*
"""

Differential Revision: https://reviews.llvm.org/D75654


Compare: https://github.com/llvm/llvm-project/compare/6333cc2a12dc...174c3eb69f19