[all-commits] [llvm/llvm-project] af3db4: [lldb] Reduce duplication in the Disassembler class

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: af3db4e9aa8fbe7e43f89cdde780c6acc35368be
      https://github.com/llvm/llvm-project/commit/af3db4e9aa8fbe7e43f89cdde780c6acc35368be
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-09 (Mon, 09 Mar 2020)

  Changed paths:
    M lldb/include/lldb/Core/Disassembler.h
    M lldb/source/Commands/CommandObjectDisassemble.cpp
    M lldb/source/Core/Disassembler.cpp
    M lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp
    M lldb/source/Target/StackFrame.cpp

  Log Message:
  -----------
  [lldb] Reduce duplication in the Disassembler class

Summary:
The class has two pairs of functions whose functionalities differ in
only how one specifies how much he wants to disasseble. One limits the
process by the size of the input memory region. The other based on the
total amount of instructions disassembled. They also differ in various
features (like error reporting) that were only added to one of the
versions.

There are various ways in which this could be addressed. This patch
does it by introducing a helper struct called "Limit", which is
effectively a pair specifying the value that you want to limit, and the
actual limit itself.

Reviewers: JDevlieghere

Subscribers: sdardis, jrtc27, atanasyan, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D75730