[all-commits] [llvm/llvm-project] 6d894a: PR45124: Don't leave behind pending cleanups when ...

[Richard Smith via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6d894afdea433879f54e5ba07e827db006645b7b
      https://github.com/llvm/llvm-project/commit/6d894afdea433879f54e5ba07e827db006645b7b
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-03-06 (Fri, 06 Mar 2020)

  Changed paths:
    M clang/lib/Sema/SemaTemplate.cpp
    M clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp

  Log Message:
  -----------
  PR45124: Don't leave behind pending cleanups when declaring implicit
deduction guides.

Previously if an implicit deduction guide had a default argument with a
cleanup, we'd leave the 'pending cleanup' flag set after declaring the
implicit guide. But it turns out that there's no reason to even
substitute into the default argument when declaring an implicit
deduction guide: we only need to record that the default argument
exists, not what it is, since we never actually form a call to a
deduction guide.